Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation to close shell extension DLLs via the custom action. Disable reboot prompt in case of the version with this change was previously already installed. #6525

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

allexzander
Copy link
Contributor

Improvement for #6003

@allexzander
Copy link
Contributor Author

Sometimes, unexplainable, the DLL host process (where the CF API shell extensions DLL is running) does not stop even though the message is sent to it. Then the installer is still able to close it. Yet, this is a big improvement. The ideal solution is explained here #6526.

@allexzander
Copy link
Contributor Author

/backport to stable-3.12

…n. Disable reboot prompt in case of the version with this change was previously already installed.

Signed-off-by: alex-z <[email protected]>
@allexzander allexzander force-pushed the feature/msi-customaction-close-shellextensions branch from 67f438e to c1719bc Compare March 19, 2024 12:56
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6525-c1719bc817421e46ba95f8919e3dc2d977ee81af-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants